allow jackson to sync versions across dep graph#221
Conversation
Allows for writing out the generated code dependencies to generate a build.gradle file in kb-sdk init
|
I can't log in to synk so ignoring those |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=========================================
Coverage 71.46% 71.46%
Complexity 703 703
=========================================
Files 46 46
Lines 3715 3715
Branches 666 666
=========================================
Hits 2655 2655
Misses 826 826
Partials 234 234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| implementation('com.fasterxml.jackson.core:jackson-annotations:2.9.9') | ||
| implementation('com.fasterxml.jackson.core:jackson-databind:2.9.9') |
There was a problem hiding this comment.
Everything seems to build and test fine, so I'm guessing the // don't upgrade yet, breaks tests comments aren't relevant. Can you go to a later 2.x version? 2.20 was the last one, I think.
Not that it matters much, I'm mostly just curious.
There was a problem hiding this comment.
I'm guessing the // don't upgrade yet, breaks tests comments aren't relevant.
I think the last PR that got rid of the hardcoded jar names in the tests fixed that
Can you go to a later 2.x version? 2.20 was the last one, I think.
I'd want to update java_common / auth / etc. first.
Jackson is on 3.1.0 now, which sounds like upgrades might be difficult
2 participants
Allows for writing out the generated code dependencies to generate a build.gradle file in kb-sdk init